ShrinkVertically v1.6.2: move config auto-adjust dim into external JS (CSP blocks inline script)

Asset/css/shrink-vertically.css

@@ -26,11 +26,19 @@
  * (BoardDragAndDrop.js: css("min-height", parent().height())). In CSS, min-height
  * beats max-height, so that inline value keeps tall columns from shrinking and our
  * max-height alone does nothing. A stylesheet !important overrides the inline
- * (non-important) min-height, so we reset it to 0 and let max-height win.
+ * (non-important) min-height so max-height can win.
+ *
+ * We override it to a NON-ZERO value, not 0: Kanboard relies on that same inline
+ * min-height to keep EMPTY columns tall enough to be a drop target, so zeroing it makes
+ * you unable to drop a card into an empty collapsed column. 250px gives a comfortable drop
+ * target (well above Kanboard's 70px .draggable-placeholder) while staying below the
+ * collapsed max-height, so the board never overflows the viewport (which would re-hide the
+ * horizontal scrollbar). Non-empty columns are unaffected -- their content is taller -- and
+ * short columns simply get this min-height, which is only cosmetic (no scrollbar).
  */
 #board td .board-task-list.board-task-list-compact {
     max-height: calc(100vh - var(--sv-shrink-offset, 240px)) !important;
-    min-height: 0 !important;
+    min-height: 250px !important;
 }
 
 /*

Asset/js/auto-adjust.js

@@ -0,0 +1,86 @@
+/*
+ * ShrinkVertically -- "Auto adjust" mode. Measure the collapsed board live and set the
+ * --sv-shrink-offset CSS variable so the columns exactly fill the remaining viewport and the
+ * native right-side vertical scrollbar is not needed. Loaded only when the setting is on
+ * (Settings -> Shrink Vertically); it overrides the static offset injected by layout/variable.php.
+ *
+ * The collapsed column height is calc(100vh - var(--sv-shrink-offset)). To fit the screen we need:
+ *     offset = (task-list top, i.e. the chrome above) + (horizontal scrollbar below) + a small margin
+ * so column_bottom + scrollbar stays within the viewport. Both terms are measured from the DOM, so
+ * this adapts to any screen size, theme, or header height.
+ *
+ * Re-measures on resize, on collapse/expand (a class toggle), and after a board refresh
+ * (BoardDragAndDrop replaces #board-container -- so, like the other plugins, the observer is bound
+ * to the STABLE parent, not to the container that gets swapped out).
+ */
+(function () {
+    "use strict";
+
+    var BOTTOM_MARGIN = 20; // breathing room below the columns (covers sub-pixel + borders so nothing overflows)
+    var scheduled = false;
+
+    function apply() {
+        scheduled = false;
+
+        var list = document.querySelector("#board .board-task-list.board-task-list-compact");
+
+        if (! list) {
+            return; // board not collapsed -> nothing to auto-size
+        }
+
+        var top = list.getBoundingClientRect().top;
+        var container = document.getElementById("board-container");
+        var bar = container ? (container.offsetHeight - container.clientHeight) : 0; // horizontal scrollbar
+
+        if (bar < 0) {
+            bar = 0;
+        }
+
+        var offset = Math.ceil(top + bar + BOTTOM_MARGIN);
+
+        if (offset < 0) {
+            offset = 0;
+        }
+
+        var next = offset + "px";
+        var root = document.documentElement;
+
+        // Only write when it actually changes, so mid-drag class churn does not thrash layout.
+        if (root.style.getPropertyValue("--sv-shrink-offset") !== next) {
+            root.style.setProperty("--sv-shrink-offset", next);
+        }
+    }
+
+    function schedule() {
+        if (! scheduled) {
+            scheduled = true;
+            window.requestAnimationFrame(apply);
+        }
+    }
+
+    function init() {
+        var container = document.getElementById("board-container");
+
+        if (! container) {
+            return; // not a board page
+        }
+
+        schedule();
+        window.addEventListener("resize", schedule);
+
+        if (window.MutationObserver && container.parentNode) {
+            new MutationObserver(schedule).observe(container.parentNode, {
+                childList: true,
+                subtree: true,
+                attributes: true,
+                attributeFilter: ["class"]
+            });
+        }
+    }
+
+    if (document.readyState === "loading") {
+        document.addEventListener("DOMContentLoaded", init);
+    } else {
+        init();
+    }
+})();

Asset/js/shrink-vertically.js

@@ -1,13 +1,17 @@
 /*
- * ShrinkVertically -- mark the two vertical-collapse menu items so it is obvious the
- * behaviour comes from this plugin and not from Kanboard core.
+ * ShrinkVertically page scripts (loaded on every page via template:layout:js). Each runs only where
+ * its elements exist, so both are no-ops elsewhere:
  *
- * Core renders these labels in app/Template/project_header/dropdown.php:
- *   .filter-vert-collapse .filter-vert-toggle-collapse  ->  "Collapse vertically"
- *   .filter-vert-expand   .filter-vert-toggle-collapse  ->  "Expand vertically"
+ *   1. addPlus() -- mark the two vertical-collapse gear-menu items with a trailing "+" so it is
+ *      obvious the behaviour comes from this plugin and not core. Core renders these labels in
+ *      app/Template/project_header/dropdown.php:
+ *        .filter-vert-collapse .filter-vert-toggle-collapse  ->  "Collapse vertically"
+ *        .filter-vert-expand   .filter-vert-toggle-collapse  ->  "Expand vertically"
+ *      Editing the rendered text (not the translation table) is locale-independent.
  *
- * We append a "+" to each so they read "Collapse vertically+" / "Expand vertically+".
- * This is locale-independent (it edits the rendered text, not the translation table).
+ *   2. syncAutoAdjust() -- on Settings -> Shrink Vertically, dim + disable the pixel-offset input
+ *      while "Auto adjust" is checked. This lives here (not an inline <script> on the config page)
+ *      because Kanboard's CSP (default-src 'self') blocks inline scripts and event handlers.
  */
 (function () {
     "use strict";
@@ -26,9 +30,31 @@
         }
     }
 
-    if (document.readyState === "loading") {
-        document.addEventListener("DOMContentLoaded", addPlus);
-    } else {
+    function syncAutoAdjust() {
+        var auto = document.getElementById("form-shrink_vertically_auto");
+        var offset = document.getElementById("form-shrink_vertically_offset");
+
+        if (! auto || ! offset) {
+            return;
+        }
+
+        function sync() {
+            offset.disabled = auto.checked;
+            offset.style.opacity = auto.checked ? "0.4" : "";
+        }
+
+        auto.addEventListener("change", sync);
+        sync();
+    }
+
+    function init() {
         addPlus();
+        syncAutoAdjust();
+    }
+
+    if (document.readyState === "loading") {
+        document.addEventListener("DOMContentLoaded", init);
+    } else {
+        init();
     }
 })();

Asset/js/top-scrollbar.js

@@ -10,6 +10,14 @@
  * track + thumb widget: it renders and behaves the same in every browser (Chrome, Firefox,
  * Safari) and on touch, and its thickness follows the --sv-bar-size setting.
  *
+ * Resilience note: after a card drag Kanboard rebuilds the board with
+ * `$("#board-container").replaceWith(data)` (BoardDragAndDrop.refresh), so the element we
+ * started with is destroyed and replaced. We therefore never cache the container: we
+ * re-resolve it on every use, listen for its scroll on `document` in the capture phase (so
+ * the listener survives the swap), and observe the STABLE parent (which is not replaced) so
+ * the widget keeps working -- previously the observer and scroll listener died with the old
+ * element, which froze the bar and lost sync after each move.
+ *
  * Loaded only when the "Add a top horizontal scrollbar" setting is enabled.
  */
 (function () {
@@ -18,14 +26,25 @@
     // Keep the thumb wide enough to grab, even on a very wide board.
     var MIN_THUMB = 24;
 
+    // Ignore a few px of residual overflow (padding / sub-pixel rounding) so a board that visually
+    // fits is treated as "no horizontal scroll" instead of showing an immovable near-full thumb.
+    var FIT_TOLERANCE = 4;
+
+    function getContainer() {
+        return document.getElementById("board-container");
+    }
+
     function init() {
-        var container = document.getElementById("board-container");
+        var container = getContainer();
 
         // Only on the board, and never add it twice.
         if (!container || document.querySelector(".sv-top-scroll")) {
             return;
         }
 
+        // The parent survives the board refresh (only #board-container is replaced).
+        var boardParent = container.parentNode;
+
         var track = document.createElement("div");
         track.className = "sv-top-scroll";
 
@@ -33,16 +52,21 @@
         thumb.className = "sv-top-scroll-thumb";
         track.appendChild(thumb);
 
-        container.parentNode.insertBefore(track, container);
+        boardParent.insertBefore(track, container);
 
         var dragging = false;
         var dragStartX = 0;
         var dragStartScrollLeft = 0;
 
         function metrics() {
+            var c = getContainer();
+            if (!c) {
+                return null;
+            }
             return {
-                viewport: container.clientWidth,
-                content: container.scrollWidth,
+                c: c,
+                viewport: c.clientWidth,
+                content: c.scrollWidth,
                 trackW: track.clientWidth
             };
         }
@@ -50,21 +74,33 @@
         function positionThumb(m, thumbW) {
             var maxScroll = m.content - m.viewport;
             var maxThumb = m.trackW - thumbW;
-            var left = maxScroll > 0 ? (container.scrollLeft / maxScroll) * maxThumb : 0;
+            var left = maxScroll > 0 ? (m.c.scrollLeft / maxScroll) * maxThumb : 0;
             thumb.style.transform = "translateX(" + Math.round(left) + "px)";
         }
 
-        // Recompute thumb width/position; hide the whole bar when nothing to scroll.
+        // The board needs scrolling only if its content exceeds the viewport by more than the
+        // tolerance (absorbs a residual px or two so a fitting board reads as "no scroll").
+        function needsScroll(m) {
+            return m && m.content - m.viewport > FIT_TOLERANCE;
+        }
+
+        // Recompute the thumb. The (light) track stays visible for a STABLE height; when the board
+        // fits, just drop the knob (thumb width 0) so it reads as "nothing to scroll" without the
+        // layout jump that hiding the whole bar would cause.
         function layout() {
             var m = metrics();
 
-            if (m.content <= m.viewport || m.trackW <= 0) {
-                track.style.display = "none";
+            if (!m || m.trackW <= 0) {
                 return;
             }
 
             track.style.display = "";
 
+            if (!needsScroll(m)) {
+                thumb.style.width = "0px";
+                return;
+            }
+
             var thumbW = Math.round(m.trackW * m.viewport / m.content);
             if (thumbW < MIN_THUMB) { thumbW = MIN_THUMB; }
             if (thumbW > m.trackW) { thumbW = m.trackW; }
@@ -73,21 +109,34 @@
             positionThumb(m, thumbW);
         }
 
-        // Board scrolled by any other means -> keep the thumb in sync.
-        container.addEventListener("scroll", function () {
+        // Keep the track directly before the (current) container after a board refresh.
+        function reattachTrack() {
+            var c = getContainer();
+            if (c && c.parentNode && track.nextSibling !== c) {
+                c.parentNode.insertBefore(track, c);
+            }
+            observeSizes();
+        }
+
+        // Board scrolled by any other means -> keep the thumb in sync. Capture-phase on
+        // document catches #board-container's (non-bubbling) scroll and survives the swap.
+        document.addEventListener("scroll", function (e) {
             if (dragging) { return; }
+            if (e.target !== getContainer()) { return; }
             var m = metrics();
-            if (m.content <= m.viewport) { return; }
+            if (!needsScroll(m)) { return; }
             positionThumb(m, thumb.offsetWidth);
-        });
+        }, true);
 
         // Drag the thumb (mouse + touch via Pointer Events).
         thumb.addEventListener("pointerdown", function (e) {
+            var c = getContainer();
+            if (!c) { return; }
             e.preventDefault();
             e.stopPropagation();
             dragging = true;
             dragStartX = e.clientX;
-            dragStartScrollLeft = container.scrollLeft;
+            dragStartScrollLeft = c.scrollLeft;
             track.classList.add("sv-dragging");
             if (thumb.setPointerCapture) {
                 thumb.setPointerCapture(e.pointerId);
@@ -97,10 +146,11 @@
         thumb.addEventListener("pointermove", function (e) {
             if (!dragging) { return; }
             var m = metrics();
+            if (!m) { return; }
             var maxThumb = m.trackW - thumb.offsetWidth;
             var maxScroll = m.content - m.viewport;
             if (maxThumb <= 0) { return; }
-            container.scrollLeft = dragStartScrollLeft + (e.clientX - dragStartX) * (maxScroll / maxThumb);
+            m.c.scrollLeft = dragStartScrollLeft + (e.clientX - dragStartX) * (maxScroll / maxThumb);
             positionThumb(m, thumb.offsetWidth);
         });
 
@@ -120,7 +170,7 @@
         track.addEventListener("pointerdown", function (e) {
             if (e.target === thumb || dragging) { return; }
             var m = metrics();
-            if (m.content <= m.viewport) { return; }
+            if (!needsScroll(m)) { return; }
 
             var thumbW = thumb.offsetWidth;
             var maxThumb = m.trackW - thumbW;
@@ -132,18 +182,52 @@
             if (targetLeft < 0) { targetLeft = 0; }
             if (targetLeft > maxThumb) { targetLeft = maxThumb; }
 
-            container.scrollLeft = (targetLeft / maxThumb) * maxScroll;
+            m.c.scrollLeft = (targetLeft / maxThumb) * maxScroll;
             positionThumb(m, thumbW);
         });
 
-        window.addEventListener("resize", layout);
+        // Single source of truth for recomputing the thumb: a ResizeObserver on the container
+        // (viewport) and #board (content). It fires exactly when the width settles/changes -- the
+        // right moment -- which also fixes the stale thumb from the first layout() running before the
+        // board finished sizing. Both are replaced on a board refresh, so re-observe the current ones
+        // (from reattachTrack). Without ResizeObserver, fall back to a window resize listener.
+        var sizeObserver = window.ResizeObserver ? new ResizeObserver(function () { layout(); }) : null;
+        var observedContainer = null;
+        var observedBoard = null;
 
-        // The board can be redrawn by AJAX polling / drag-and-drop; keep sizes current.
-        if (window.MutationObserver) {
-            new MutationObserver(layout).observe(container, { childList: true, subtree: true });
+        function observeSizes() {
+            if (!sizeObserver) {
+                layout();
+                return;
+            }
+
+            var c = getContainer();
+            var b = document.getElementById("board");
+
+            if (c && c !== observedContainer) {
+                if (observedContainer) { sizeObserver.unobserve(observedContainer); }
+                sizeObserver.observe(c);
+                observedContainer = c;
+            }
+
+            if (b && b !== observedBoard) {
+                if (observedBoard) { sizeObserver.unobserve(observedBoard); }
+                sizeObserver.observe(b);
+                observedBoard = b;
+            }
         }
 
-        layout();
+        if (!sizeObserver) {
+            window.addEventListener("resize", layout);
+        }
+
+        // Re-seat the track and re-observe after #board-container is replaced by a card move / AJAX
+        // polling (we watch the STABLE parent, since the container itself is swapped out).
+        if (window.MutationObserver) {
+            new MutationObserver(reattachTrack).observe(boardParent, { childList: true, subtree: true });
+        }
+
+        observeSizes();
     }
 
     if (document.readyState === "loading") {

Controller/ConfigController.php

@@ -23,6 +23,7 @@ class ConfigController extends BaseController
         $offset = (int) $this->configModel->get('shrink_vertically_offset', self::DEFAULT_OFFSET);
         $barSize = (int) $this->configModel->get('shrink_vertically_bar_size', self::DEFAULT_BAR_SIZE);
         $topScrollbar = (int) $this->configModel->get('shrink_vertically_top_scrollbar', 1);
+        $auto = (int) $this->configModel->get('shrink_vertically_auto', 0);
 
         $this->response->html($this->helper->layout->config('shrinkVertically:config/show', array(
             'title' => t('Settings').' > '.t('Shrink Vertically'),
@@ -30,6 +31,7 @@ class ConfigController extends BaseController
                 'shrink_vertically_offset' => $offset,
                 'shrink_vertically_bar_size' => $barSize,
                 'shrink_vertically_top_scrollbar' => $topScrollbar,
+                'shrink_vertically_auto' => $auto,
             ),
             'errors' => array(),
         )));
@@ -39,18 +41,24 @@ class ConfigController extends BaseController
     {
         $values = $this->request->getValues();
 
-        $offset = isset($values['shrink_vertically_offset']) ? (int) $values['shrink_vertically_offset'] : self::DEFAULT_OFFSET;
+        // In auto mode the offset input is disabled client-side, so the browser does not submit it.
+        // Fall back to the stored value (not the default) so enabling auto never wipes the manual offset.
+        $offset = isset($values['shrink_vertically_offset'])
+            ? (int) $values['shrink_vertically_offset']
+            : (int) $this->configModel->get('shrink_vertically_offset', self::DEFAULT_OFFSET);
         $offset = max(self::MIN_OFFSET, min(self::MAX_OFFSET, $offset));
 
         $barSize = isset($values['shrink_vertically_bar_size']) ? (int) $values['shrink_vertically_bar_size'] : self::DEFAULT_BAR_SIZE;
         $barSize = max(self::MIN_BAR_SIZE, min(self::MAX_BAR_SIZE, $barSize));
 
         $topScrollbar = isset($values['shrink_vertically_top_scrollbar']) ? 1 : 0;
+        $auto = isset($values['shrink_vertically_auto']) ? 1 : 0;
 
         if ($this->configModel->save(array(
             'shrink_vertically_offset' => $offset,
             'shrink_vertically_bar_size' => $barSize,
             'shrink_vertically_top_scrollbar' => $topScrollbar,
+            'shrink_vertically_auto' => $auto,
         ))) {
             $this->flash->success(t('Settings saved successfully.'));
         } else {

Plugin.php

@@ -32,6 +32,14 @@ class Plugin extends Base
                 'template' => 'plugins/ShrinkVertically/Asset/js/top-scrollbar.js',
             ));
         }
+
+        // Optional: auto-adjust the collapsed column height to the screen (measured live on the
+        // board), overriding the static pixel offset so the vertical scrollbar is not needed.
+        if ((int) $this->configModel->get('shrink_vertically_auto', 0) === 1) {
+            $this->hook->on('template:layout:js', array(
+                'template' => 'plugins/ShrinkVertically/Asset/js/auto-adjust.js',
+            ));
+        }
     }
 
     public function getPluginName()
@@ -51,7 +59,7 @@ class Plugin extends Base
 
     public function getPluginVersion()
     {
-        return '1.4.0';
+        return '1.6.2';
     }
 
     public function getPluginHomepage()

README.md

@@ -86,6 +86,11 @@ These settings are global (per Kanboard instance) and admin-only. Go to
   in the page head as the `--sv-shrink-offset` CSS variable. Increase it if the scrollbar
   is still clipped (for example with a taller theme header); decrease it to make the
   collapsed columns taller. Default: 240.
+- **Auto adjust** -- instead of a fixed offset, measure the collapsed board live and size
+  the columns to fit the screen automatically, so the right-side vertical scrollbar is not
+  needed. It re-measures on window resize, on collapse/expand, and after a board refresh.
+  While enabled, the pixel-offset field above is disabled and dimmed (the measured value is
+  used instead). Loaded as `Asset/js/auto-adjust.js` only when the option is on. Default: off.
 - **Top Horizontal Scrollbar thickness in pixels** -- thickness of the custom top
   scrollbar (all browsers). Injected as the `--sv-bar-size` CSS variable. Default: 25.
 - **Add a top horizontal scrollbar to the board** -- toggles the mirrored top scrollbar
@@ -94,3 +99,19 @@ These settings are global (per Kanboard instance) and admin-only. Go to
 ## License
 
 AGPL-3.0. See LICENSE.
+
+## More Kanboard plugins by Ruben (drbeco)
+
+All free and AGPL-3.0, at [code.beco.cc](https://code.beco.cc/beco):
+
+- **[RecoReco](https://code.beco.cc/beco/RecoReco)** -- calendar-scheduled recurring cards (yearly,
+  monthly, weekly, daily), driven by the card due date.
+- **[FinanceBuddy](https://code.beco.cc/beco/FinanceBuddy)** -- attach a money value (debit/credit
+  and installments) to cards, shown on the card and totalled per column.
+- **[OrganonTweaks](https://code.beco.cc/beco/OrganonTweaks)** -- an umbrella of small
+  quality-of-life board tweaks: remove an empty column, always show the comment icon, emphasize due
+  dates, extra search keywords and shared board filters, and more.
+- **[BulkMoveTasks](https://code.beco.cc/beco/BulkMoveTasks)** -- move every task from one board
+  column to another in a single action.
+- **[TweakDrag](https://code.beco.cc/beco/TweakDrag)** -- board drag and touch niceties:
+  drag-to-scroll, a wider column gap, and smoother card dragging.

Template/config/show.php

@@ -11,6 +11,11 @@
         <p class="form-help">
             <?= t('Pixels reserved above and below the vertically collapsed board columns (page header, column header and the horizontal scrollbar). A larger value makes the columns shorter. Default: 240.') ?>
         </p>
+
+        <?= $this->form->checkbox('shrink_vertically_auto', t('Auto adjust (fit columns to the screen automatically)'), 1, isset($values['shrink_vertically_auto']) && $values['shrink_vertically_auto'] == 1, '', array('id' => 'form-shrink_vertically_auto')) ?>
+        <p class="form-help">
+            <?= t('When enabled, the collapsed column height is measured live on the board to fit the screen, so the right-side vertical scrollbar is not needed. The pixel offset above is then ignored (shown dimmed).') ?>
+        </p>
     </fieldset>
 
     <fieldset>
@@ -32,3 +37,5 @@
         <button type="submit" class="btn btn-blue"><?= t('Save') ?></button>
     </div>
 </form>
+<?php /* The "Auto adjust" checkbox dims/disables the offset input via Asset/js/shrink-vertically.js
+         (loaded globally). An inline <script> here would be blocked by Kanboard's CSP. */ ?>

VERSION

@@ -1 +1 @@
-ShrinkVertically v1.4
+ShrinkVertically v1.6.2