fix Always-off (on/off/default safe values) + bump emphasis to 1.375em (v1.4.2)

Controller/ConfigController.php

@@ -31,12 +31,14 @@ class ConfigController extends BaseController
         $alwaysCommentIcon = isset($values['organon_tweaks_always_comment_icon']) ? 1 : 0;
         $keepScroll = isset($values['organon_tweaks_keep_scroll']) ? 1 : 0;
         $quickClickOnly = isset($values['organon_tweaks_quick_click_only']) ? 1 : 0;
+        $enhanceRecurrence = isset($values['organon_tweaks_enhance_recurrence']) ? 1 : 0;
         $emphasizeDueDateDefault = isset($values['organon_tweaks_emphasize_duedate_default']) ? 1 : 0;
 
         if ($this->configModel->save(array(
             'organon_tweaks_always_comment_icon' => $alwaysCommentIcon,
             'organon_tweaks_keep_scroll' => $keepScroll,
             'organon_tweaks_quick_click_only' => $quickClickOnly,
+            'organon_tweaks_enhance_recurrence' => $enhanceRecurrence,
             'organon_tweaks_emphasize_duedate_default' => $emphasizeDueDateDefault,
         ))) {
             $this->flash->success(t('Settings saved successfully.'));

Helper/OrganonProjectHelper.php

@@ -9,7 +9,11 @@ use Kanboard\Core\Base;
  *
  * Resolves the 3-state "emphasize due date" setting for the CURRENT board (read from the route
  * project_id, which the router populates for pretty URLs before the layout renders):
- *   per-board '1' -> on, '0' -> off, 'default'/absent -> follow the LIVE global default.
+ *   per-board 'on' -> on, 'off' -> off, 'default'/absent -> follow the LIVE global default.
+ *
+ * The stored values are the non-falsy strings 'on'/'off' (not '1'/'0'): Kanboard's
+ * MetadataModel::get() uses `?:`, and PHP treats the string "0" as falsy, so a stored "0" would
+ * come back as the 'default' fallback and "Always off" would never be honored.
  */
 class OrganonProjectHelper extends Base
 {
@@ -31,11 +35,11 @@ class OrganonProjectHelper extends Base
 
         $value = $this->projectMetadataModel->get($project_id, self::EMPHASIZE_KEY, 'default');
 
-        if ($value === '1') {
+        if ($value === 'on') {
             return true;
         }
 
-        if ($value === '0') {
+        if ($value === 'off') {
             return false;
         }
 

Plugin.php

@@ -83,7 +83,7 @@ class Plugin extends Base
 
     public function getPluginVersion()
     {
-        return '1.4.0';
+        return '1.4.2';
     }
 
     public function getPluginHomepage()

Template/config/show.php

@@ -27,7 +27,7 @@
     </fieldset>
 
     <fieldset>
-        <?= $this->form->checkbox('organon_tweaks_enhance_recurrence', t('Enhance the recurrence dialog'), 1, isset($values['organon_tweaks_enhance_recurrence']) && $values['organon_tweaks_enhance_recurrence'] == 1) ?>
+        <?= $this->form->checkbox('organon_tweaks_enhance_recurrence', t('Enhance the native recurrence dialog'), 1, isset($values['organon_tweaks_enhance_recurrence']) && $values['organon_tweaks_enhance_recurrence'] == 1) ?>
         <p class="form-help">
             <?= t('In the native "Edit recurrence" dialog, replace the Generate recurrent task dropdown with Yes/No radio buttons (one click), and add a [+7] button next to the factor that adds 7 (one week of days).') ?>
         </p>

Template/layout/emphasize_duedate.php

@@ -1,3 +1,3 @@
 <?php if ($this->OrganonProjectHelper->isEmphasizeDueDate()): ?>
-<style>.task-date { font-size: 1.25em; font-weight: bold; }</style>
+<style>.task-date { font-size: 1.375em; font-weight: bold; }</style>
 <?php endif ?>

Template/project/integration.php

@@ -1,4 +1,4 @@
-<?php $choice = isset($values['organon_tweaks_emphasize_duedate']) && in_array($values['organon_tweaks_emphasize_duedate'], array('1', '0'), true) ? $values['organon_tweaks_emphasize_duedate'] : 'default' ?>
+<?php $choice = isset($values['organon_tweaks_emphasize_duedate']) && in_array($values['organon_tweaks_emphasize_duedate'], array('on', 'off'), true) ? $values['organon_tweaks_emphasize_duedate'] : 'default' ?>
 
 <h3><i class="fa fa-umbrella fa-fw" aria-hidden="true"></i> <?= t('OrganonTweaks') ?></h3>
 <div class="listing">
@@ -8,10 +8,10 @@
         <input type="radio" name="organon_tweaks_emphasize_duedate" value="default" <?= $choice === 'default' ? 'checked="checked"' : '' ?>> <?= t('Use default') ?>
     </label>
     <label style="display:inline-block; margin-right:16px;">
-        <input type="radio" name="organon_tweaks_emphasize_duedate" value="1" <?= $choice === '1' ? 'checked="checked"' : '' ?>> <?= t('Always on') ?>
+        <input type="radio" name="organon_tweaks_emphasize_duedate" value="on" <?= $choice === 'on' ? 'checked="checked"' : '' ?>> <?= t('Always on') ?>
     </label>
     <label style="display:inline-block; margin-right:16px;">
-        <input type="radio" name="organon_tweaks_emphasize_duedate" value="0" <?= $choice === '0' ? 'checked="checked"' : '' ?>> <?= t('Always off') ?>
+        <input type="radio" name="organon_tweaks_emphasize_duedate" value="off" <?= $choice === 'off' ? 'checked="checked"' : '' ?>> <?= t('Always off') ?>
     </label>
 
     <p class="form-help">

VERSION

@@ -1 +1 @@
-OrganonTweaks v1.4
+OrganonTweaks v1.4.2