v1.8.2 admin global settings groupped

Asset/js/title-click-edit.js

@@ -1,11 +1,13 @@
 /*
  * OrganonTweaks -- clicking a task title opens the edit modal instead of the read-only card view,
- * reusing Kanboard's own modal opener (KB.modal.open). Board part: the title is a link, and a hidden
+ * reusing Kanboard's own modal opener (KB.modal.open).
- * marker rendered next to it (only when the user may edit) carries the server-generated edit URL.
+ *   - Board: the title is a link, and a hidden marker rendered next to it (only when the user may
+ *     edit) carries the server-generated edit URL.
+ *   - Card view: the title (#task-summary > h2) opens the same modal via #task-view's data-edit-url,
+ *     but only when the user may edit -- detected by the presence of the sidebar "Edit" action.
  *
- * A capture-phase delegated click is used so it (a) runs before Kanboard's own bubble-phase handlers,
+ * A capture-phase delegated click runs before Kanboard's own handlers, survives the board's AJAX
- * (b) survives the board's AJAX re-renders without re-binding, and (c) stops both the link navigation
+ * re-renders, and stops both the link navigation and the card's own click.
- * and the card's own click.
  */
 (function () {
     "use strict";
@@ -16,6 +18,11 @@
         }
     }
 
+    // The sidebar "Edit the task" action (fa-edit) only renders when the current user may edit.
+    function canEdit() {
+        return !!document.querySelector(".sidebar a i.fa-edit");
+    }
+
     document.addEventListener("click", function (e) {
         if (!e.target || !e.target.closest) {
             return;
@@ -31,6 +38,30 @@
                 e.stopPropagation();
                 openEdit(marker.getAttribute("data-url"));
             }
+            return;
+        }
+
+        // Card-view title -> open the same edit modal (#task-view carries the edit URL).
+        var title = e.target.closest("#task-summary > h2");
+        if (title && canEdit()) {
+            var taskView = document.querySelector("#task-view");
+            if (taskView && taskView.getAttribute("data-edit-url")) {
+                openEdit(taskView.getAttribute("data-edit-url"));
+            }
         }
     }, true);
+
+    // Make the card-view title look clickable (the board title is already a link).
+    function markTitle() {
+        var title = document.querySelector("#task-summary > h2");
+        if (title && canEdit()) {
+            title.style.cursor = "pointer";
+        }
+    }
+
+    if (document.readyState !== "loading") {
+        markTitle();
+    } else {
+        document.addEventListener("DOMContentLoaded", markTitle);
+    }
 })();

Plugin.php

@@ -128,7 +128,7 @@ class Plugin extends Base
 
     public function getPluginVersion()
     {
-        return '1.7.2';
+        return '1.8.2';
     }
 
     public function getPluginHomepage()

Template/config/show.php

@@ -22,13 +22,6 @@
         </p>
     </fieldset>
 
-    <fieldset>
-        <?= $this->form->checkbox('organon_tweaks_quick_click_only', t('Open a card only on a quick click'), 1, isset($values['organon_tweaks_quick_click_only']) && $values['organon_tweaks_quick_click_only'] == 1) ?>
-        <p class="form-help">
-            <?= t('A press held longer than 120 ms is treated as a drag, so releasing it does not open the card. Fixes a drag sometimes opening the card on release.') ?>
-        </p>
-    </fieldset>
-
     <fieldset>
         <?= $this->form->checkbox('organon_tweaks_enhance_recurrence', t('Enhance the native recurrence dialog'), 1, isset($values['organon_tweaks_enhance_recurrence']) && $values['organon_tweaks_enhance_recurrence'] == 1) ?>
         <p class="form-help">
@@ -52,6 +45,9 @@
     <fieldset>
         <legend><?= t('Card interaction') ?></legend>
 
+        <?= $this->form->checkbox('organon_tweaks_quick_click_only', t('Open a card only on a quick click'), 1, isset($values['organon_tweaks_quick_click_only']) && $values['organon_tweaks_quick_click_only'] == 1) ?>
+        <p class="form-help"><?= t('A press held longer than 120 ms is treated as a drag, so releasing it does not open the card. Fixes a drag sometimes opening the card on release.') ?></p>
+
         <?= $this->form->checkbox('organon_tweaks_shortcut_labels', t('Show keyboard shortcuts on the task menu'), 1, isset($values['organon_tweaks_shortcut_labels']) && $values['organon_tweaks_shortcut_labels'] == 1) ?>
         <p class="form-help"><?= t('Adds the existing key hints (e, s, c, l) next to the task Actions items.') ?></p>
 

VERSION

@@ -1 +1 @@
-OrganonTweaks v1.7.2
+OrganonTweaks v1.8.2