beco/FinanceBuddy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clamp installment at total+1 as RecoReco plan-complete tombstone (v1.1.1)

Browse Source
This commit is contained in:
Ruben Carlo Benante
2026-07-10 09:13:36 -03:00
parent 3e0cf10d6c
commit eac8617723
4 changed files with 36 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Model/FinancePersistence.php
View File

@@ -190,9 +190,12 @@ class FinancePersistence extends Base
}
/**
* Advance a task's current installment by one, in place. A finite plan clamps at the total
* (p10/10 stays p10/10); an open-ended one (no total) increments unbounded (p2 -> p3). Cards
* with no numeric current installment are left alone.
* Advance a task's current installment by one, in place. A finite plan clamps at total+1, one
* past the last installment: that overflow is the "plan complete" tombstone (p4/3) that RecoReco
* reads to stop a following recurrence, and it caps runaway when nothing follows. Clones still
* read p1/total .. pTotal/total because a clone snapshots current BEFORE this advance. An
* open-ended plan (no total) increments unbounded (p2 -> p3); cards with no numeric current
* installment are left alone.
*/
private function advanceInstallment($task_id)
{
@@ -205,8 +208,8 @@ class FinancePersistence extends Base
$total = $this->taskMetadataModel->get($task_id, FinanceHelper::INSTALLMENT_TOTAL_KEY, '');
$next = (int) $current + 1;
if ($total !== '' && ctype_digit((string) $total) && $next > (int) $total) {
$next = (int) $total;
if ($total !== '' && ctype_digit((string) $total) && $next > (int) $total + 1) {
$next = (int) $total + 1;
}
$this->taskMetadataModel->save($task_id, array(